Migrate to Swift 5️⃣.9️⃣ #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveenmindera
approved these changes
Apr 18, 2024
p4checo
force-pushed
the
migrate-to-swift-5-9
branch
5 times, most recently
from
8a8964b to
bdc2b3c
Compare
Migrate CI to macOS 14 image and Xcode 15.2 which contains Swift 5.9, and migrate Danger CI to run on ubuntu 22.04. https://github.com/actions/runner-images/blob/main/images/macos/macos-14-arm64-Readme.md#xcode ## Changes - Update Xcode references to 15.2 and Swift references to 5.9. reasons. - Update destination device to iPhone 15 Pro. - Improve SwiftLint setup and fix warnings. - Update `README.md`. - Apply Xcode's recommended project settings. - Improve SwiftLint setup: + Move SwiftLint run script to Alicerce target + Add SwiftLint as SPM plugin on Alicerce Package (via Package.swift) - Improve CI: + Update GH Actions' versions + Specify SwiftLint version for Danger CI + Place DerivedData outside checkout folder + Enable SPM caching and artifact upload in CI + Always upload artifacts + Disable Package and Macro validation for CI + Add Homebrew bundle install and caching + Add multiple workarounds for Carthage validation + Cancel in progress PR builds on push
p4checo
force-pushed
the
migrate-to-swift-5-9
branch
from
bdc2b3c to
00e7ee8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #267 +/- ##
==========================================
- Coverage 96.03% 95.09% -0.95%
==========================================
Files 101 101
Lines 4996 3384 -1612
==========================================
- Hits 4798 3218 -1580
+ Misses 198 166 -32 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterMotivation and Context
Migrate CI to macOS 14 image and Xcode 15.2 which contains Swift 5.9, and migrate Danger CI to run on ubuntu 22.04.
https://github.com/actions/runner-images/blob/main/images/macos/macos-14-arm64-Readme.md#xcode
Description
Update Xcode references to 15.2 and Swift references to 5.9.
Update destination device to iPhone 15 Pro.
Improve SwiftLint setup and fix warnings.
Update
README.md.Apply Xcode's recommended project settings.